trivago / parallel-webpack

Builds multi-config webpack projects in parallel

BSD 3-Clause "New" or "Revised" License

1.48k stars 96 forks source link

passing promise to callee #71

Closed oleg-andreyev closed 6 years ago

oleg-andreyev commented 6 years ago

Hi,

First of all thanks for this great lib, it improved our builds ~3x times (maybe even more!)

In my company, we are using Grunt to manage various tasks for building frontend, like webpack, sprites and etc.

I'd like to have the ability to run this lib using Grunt (or from any other script), but I need to have access to a Promise which is returned by run operation.

What's done:

[x] Reduce one branch of if-stmt
[x] export promise from run

coveralls commented 6 years ago

Coverage increased (+6.4%) to 93.401% when pulling 616d0c9ab11f925d4735ebd930e88d669d65dbad on oleg-andreyev:controled-run into 81227286337c997429577e2df1c49368e35a1227 on trivago:master.

efegurkan commented 6 years ago

Hello,

Thanks for your PR.

I don't know your use case If you need anything specific etc. , and I am just curious if you can you achieve the same thing via node API instead of using ?

oleg-andreyev commented 6 years ago

@efegurkan damn, I've missed that! Thanks!