search

trivago / parallel-webpack

Builds multi-config webpack projects in parallel
BSD 3-Clause "New" or "Revised" License
1.48k stars 96 forks source link

update lodash.endswith require #72

Closed oleg-andreyev closed 6 years ago

oleg-andreyev commented 6 years ago

Update lodash.endswith require stmt because having:

TypeError: endsWith is not a function
    at getMatchingLoaderFn (/home/sites/oleg.andreyev/src/opcart/node_modules/parallel-webpack/src/loadConfigurationFile.js:30:12)
    at default (/home/sites/oleg.andreyev/src/opcart/node_modules/parallel-webpack/src/loadConfigurationFile.js:51:19)
    at module.exports (/home/sites/oleg.andreyev/src/opcart/node_modules/parallel-webpack/src/webpackWorker.js:67:18)
    at handle (/home/sites/oleg.andreyev/src/opcart/node_modules/worker-farm/lib/child/index.js:44:8)
    at process.<anonymous> (/home/sites/oleg.andreyev/src/opcart/node_modules/worker-farm/lib/child/index.js:51:3)
    at emitTwo (events.js:106:13)
    at process.emit (events.js:191:7)
    at process.nextTick (internal/child_process.js:744:12)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)

Usage Ref.: https://www.npmjs.com/package/lodash.endswith

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 86.998% when pulling 67e1006b3568d61ba68d9e6dc1cd010955b548d1 on oleg-andreyev:update-lodash-endswith-usage into 81227286337c997429577e2df1c49368e35a1227 on trivago:master.

efegurkan commented 6 years ago

I am re-triggering travis build, Looks good to me :)