search

trivago / parallel-webpack

Builds multi-config webpack projects in parallel
BSD 3-Clause "New" or "Revised" License
1.48k stars 96 forks source link

name/output.filename should not be required #92

Open mzealey opened 5 years ago

mzealey commented 5 years ago

Explain the problem

name or output.filename parameters are required

Expected Behaviour

With webpack 4 at least these were not present in my config prior to installing parallel-webpack (the output directories were different as I have different build versions for different platforms)

Actual Behaviour

Dies in webpackWorker.js : getAppName due to parameter not existing.

npetkov commented 4 years ago

I think the issue is caused by getAppName expecting a configuration object. 

function getAppName(webpackConfig) {
    var appName = webpackConfig.name || webpackConfig.output.filename;
...

Exporting functions instead of configuration objects is obviously a no-go.