srobertson
commented
11 years ago Thanks! I'm a bit busy right now, so I added you as a committer. Feel free to merge your pull request! Greatly appreciated!
On Thu, Mar 21, 2013 at 3:59 PM, oskarpearson notifications@github.comwrote:
Attached are two very minor patches that make things easier for new users.
The bin/read code incorrectly searched for the PBTreeDictReader object in the 'libs' directory, instead of 'lib'.
The bin/remote_read code had two commented-out parameters at the first two parameters of the object initialisation, when it should actually be the
last two parameters.
You can merge this Pull Request by running
git pull https://github.com/oskarpearson/common_crawl_index master
Or view, comment on, or merge it at:
https://github.com/trivio/common_crawl_index/pull/14 Commit Summary
- Changed path for the pbtree module from 'libs' to 'lib', so as to stop the error 'ImportError: No module named libs.pbtree'
- Corrected the order of the AWS access_key and access_secret parameters. They now match the order defined in BotoMap's init method
File Changes
- M bin/readhttps://github.com/trivio/common_crawl_index/pull/14/files#diff-0(2)
- M bin/remote_readhttps://github.com/trivio/common_crawl_index/pull/14/files#diff-1(4)
Patch Links:
-- Scott
"There was a time when the internet answered all my questions. Now it just repeats them. - SDR"
Attached are two very minor patches that make things easier for new users.
The bin/read code incorrectly searched for the PBTreeDictReader object in the 'libs' directory, instead of 'lib'.
The bin/remote_read code had two commented-out parameters at the first two parameters of the object initialisation, when it should actually be the last two parameters.