search

trixi-framework / HOHQMesh

High Order Hex-Quad Mesh (HOHQMesh) package to automatically generate all-quadrilateral meshes with high order boundary information.
https://trixi-framework.github.io/HOHQMesh
Other
52 stars 8 forks source link

Rename `master` to `main` where relevant #15

Closed sloede closed 3 years ago

sloede commented 3 years ago

In keeping with the wider GitHub and code development community, I propose to rename the default branch from master to main, as we have done for virtually all other repositories. While on the surface it seems to be a political question, the overwhelming trend is moving to main: new repos on GitHub use main by default, and git itself has implemented the ability to change the default branch (see more details here). Thus I also think it makes sense from the "principle of least astonishment" for other users.

For new users, this change is transparent, since when they clone from GitHub they will automatically check out main instead of master. For existing users, it is a two-liner to rename master to main in pre-existing local clones. However, not renaming anything will work just as well, since GitHub internally forwards all references to master to main.

Note: Please do not merge this until the actual name change has been applied to the GitHub repo.

codecov[bot] commented 3 years ago

Codecov Report

Merging #15 (a7778a2) into master (02248fa) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   57.12%   57.12%           
=======================================
  Files          65       65           
  Lines        9470     9470           
=======================================
  Hits         5410     5410           
  Misses       4060     4060
Flag Coverage Δ
unittests 57.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 02248fa...a7778a2. Read the comment docs.

sloede commented 3 years ago

I se no reason why not, but does this affect PR14?

Now that #14 is already merged, this question is moot, but no, it wouldn't have affected it. GitHub automatically redirects all PRs to the new default branch.