search

trixi-framework / HOHQMesh

High Order Hex-Quad Mesh (HOHQMesh) package to automatically generate all-quadrilateral meshes with high order boundary information.
https://trixi-framework.github.io/HOHQMesh
Other
45 stars 8 forks source link

PR for uninitializeds #42

Closed DavidAKopriva closed 2 years ago

DavidAKopriva commented 2 years ago

initialize firstCharacterIsDigit

codecov[bot] commented 2 years ago

Codecov Report

Merging #42 (6078bc4) into main (8a539e9) will increase coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   67.50%   67.55%   +0.05%     
==========================================
  Files          68       68              
  Lines       10200    10203       +3     
==========================================
+ Hits         6885     6893       +8     
+ Misses       3315     3310       -5
Flag Coverage Δ
unittests 67.55% <100.00%> (+0.05%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Source/Testing/CurveTests.f90 100.00% <ø> (ø)
...Curves/ContinuousCurves/EquationEvaluatorClass.f90 82.68% <100.00%> (+1.10%) :arrow_up:
Source/IO/MeshOutputMethods.f90 69.94% <100.00%> (+0.16%) :arrow_up:
Source/Surfaces/BiCubicClass.f90 98.61% <100.00%> (+0.03%) :arrow_up:
Source/Surfaces/DataFileTopographyClass.f90 77.77% <100.00%> (+0.22%) :arrow_up:
Source/Testing/MeshingTests.f90 88.52% <100.00%> (+0.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8a539e9...6078bc4. Read the comment docs.

andrewwinters5000 commented 2 years ago

Correct me if I am wrong @sloede but I believe the strategy is the following:

  1. Close #39 without merging because this PR fixes the errors.
  2. Merge this PR into main.
  3. Merge new main into #43 and make sure everything passes.
  4. Merge #43 into main in order to activate Valgrind testing automatically for future development.
sloede commented 2 years ago

Correct me if I am wrong @sloede but I believe the strategy is the following:

1. Close [Fix Windows CI errors #39](https://github.com/trixi-framework/HOHQMesh/pull/39) without merging because this PR fixes the errors.

2. Merge this PR into `main`.

3. Merge new `main` into [Add Valgrind memory check to CI tests on Linux #43](https://github.com/trixi-framework/HOHQMesh/pull/43) and make sure everything passes.

4. Merge [Add Valgrind memory check to CI tests on Linux #43](https://github.com/trixi-framework/HOHQMesh/pull/43) into `main` in order to activate Valgrind testing automatically for future development.

Exactly!