search

trixi-framework / HOHQMesh

High Order Hex-Quad Mesh (HOHQMesh) package to automatically generate all-quadrilateral meshes with high order boundary information.
https://trixi-framework.github.io/HOHQMesh
Other
52 stars 8 forks source link

Update floating point testing #66

Closed DavidAKopriva closed 1 year ago

DavidAKopriva commented 1 year ago

In response to failures, FTOL was modified to use combinations of absolute and relative error testing. This also has the code replacements for the FMM routines and the modification at row-end corners. The results are slightly different (usually 3rd or 4th place) than previous benchmarks, so those were re-run.

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (CodeReplacement@45e004c). Click here to learn what that means. The diff coverage is n/a.

@@                Coverage Diff                 @@
##             CodeReplacement      #66   +/-   ##
==================================================
  Coverage                   ?   73.98%           
==================================================
  Files                      ?       67           
  Lines                      ?    10164           
  Branches                   ?        0           
==================================================
  Hits                       ?     7520           
  Misses                     ?     2644           
  Partials                   ?        0
Flag Coverage Δ
unittests 73.98% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

DavidAKopriva commented 1 year ago

That file shouldn't be in the makefile or the repo anymore.

andrewwinters5000 commented 1 year ago

That file shouldn't be in the makefile or the repo anymore.

Yes, you are right. I was looking at the wrong coverage report. I tracked down that the new uncovered lines are the errors that get thrown if you do not provide enough points for the cubic spline, i.e., N < 4.