trixi-framework / HOHQMesh

High Order Hex-Quad Mesh (HOHQMesh) package to automatically generate all-quadrilateral meshes with high order boundary information.
https://trixi-framework.github.io/HOHQMesh
Other
45 stars 8 forks source link

Add test with `ifort` compiler #76

Closed sloede closed 8 months ago

codecov[bot] commented 10 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (f47fe31) 74.15% compared to head (f8bd2ee) 74.19%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #76 +/- ## ========================================== + Coverage 74.15% 74.19% +0.03% ========================================== Files 67 67 Lines 10164 10155 -9 ========================================== - Hits 7537 7534 -3 + Misses 2627 2621 -6 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/HOHQMesh/pull/76/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trixi-framework/HOHQMesh/pull/76/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `74.19% <93.65%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/trixi-framework/HOHQMesh/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [Source/3DSource/3DMeshController.f90](https://app.codecov.io/gh/trixi-framework/HOHQMesh/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#diff-U291cmNlLzNEU291cmNlLzNETWVzaENvbnRyb2xsZXIuZjkw) | `93.13% <100.00%> (ø)` | | | [Source/3DSource/ReaderExceptions.f90](https://app.codecov.io/gh/trixi-framework/HOHQMesh/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#diff-U291cmNlLzNEU291cmNlL1JlYWRlckV4Y2VwdGlvbnMuZjkw) | `0.00% <ø> (ø)` | | | [Source/3DSource/SimpleSweep.f90](https://app.codecov.io/gh/trixi-framework/HOHQMesh/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#diff-U291cmNlLzNEU291cmNlL1NpbXBsZVN3ZWVwLmY5MA==) | `90.32% <ø> (ø)` | | | [Source/3DSource/SweeperClass.f90](https://app.codecov.io/gh/trixi-framework/HOHQMesh/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#diff-U291cmNlLzNEU291cmNlL1N3ZWVwZXJDbGFzcy5mOTA=) | `72.72% <ø> (ø)` | | | [Source/Curves/ContinuousCurves/SMCircularArc.f90](https://app.codecov.io/gh/trixi-framework/HOHQMesh/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#diff-U291cmNlL0N1cnZlcy9Db250aW51b3VzQ3VydmVzL1NNQ2lyY3VsYXJBcmMuZjkw) | `51.16% <ø> (ø)` | | | [...ce/Curves/DiscreteCurves/FRSegmentedCurveClass.f90](https://app.codecov.io/gh/trixi-framework/HOHQMesh/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#diff-U291cmNlL0N1cnZlcy9EaXNjcmV0ZUN1cnZlcy9GUlNlZ21lbnRlZEN1cnZlQ2xhc3MuZjkw) | `72.77% <ø> (ø)` | | | [...Curves/DiscreteCurves/SegmentedCurveArrayClass.f90](https://app.codecov.io/gh/trixi-framework/HOHQMesh/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#diff-U291cmNlL0N1cnZlcy9EaXNjcmV0ZUN1cnZlcy9TZWdtZW50ZWRDdXJ2ZUFycmF5Q2xhc3MuZjkw) | `67.24% <ø> (ø)` | | | [Source/Foundation/Shortcuts.f90](https://app.codecov.io/gh/trixi-framework/HOHQMesh/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#diff-U291cmNlL0ZvdW5kYXRpb24vU2hvcnRjdXRzLmY5MA==) | `81.48% <ø> (ø)` | | | [Source/IO/MeshOutputMethods.f90](https://app.codecov.io/gh/trixi-framework/HOHQMesh/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#diff-U291cmNlL0lPL01lc2hPdXRwdXRNZXRob2RzLmY5MA==) | `97.80% <100.00%> (ø)` | | | [Source/Mesh/BoundaryEdgeCleaning.f90](https://app.codecov.io/gh/trixi-framework/HOHQMesh/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#diff-U291cmNlL01lc2gvQm91bmRhcnlFZGdlQ2xlYW5pbmcuZjkw) | `96.02% <100.00%> (ø)` | | | ... and [24 more](https://app.codecov.io/gh/trixi-framework/HOHQMesh/pull/76?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sloede commented 10 months ago

I'll leave fixing the actual ifort errors to you, @andrewwinters5000 @DavidAKopriva. Note that once the errors are fixed, please do not merge this PR immediately since I would like to verify first that caching the compiler files works as expected.

sloede commented 8 months ago

Good news: Intel has fixed the broken APT certificate and we can run tests with ifort again.

Bad news: the ifort tests fail with a segfault

andrewwinters5000 commented 8 months ago

Okay, the valgrind jobs all still fail because something cannot be fetched properly using apt-get. @sloede have you encountered such issues recently in other repos?

sloede commented 8 months ago

Try adding a

sudo apt update

before the following line: https://github.com/trixi-framework/HOHQMesh/blob/f47fe3151fbf5dfd393de60ba37455d49e3b3b21/.github/workflows/ci.yml#L138

This might help fix/prevent these kind of errors (it's an oversight of mine).

sloede commented 8 months ago

Great job making HM more robust and portable 💪 Nothing to add from my side, so feel free to merge any time once you two are happy with it.