Closed DavidAKopriva closed 2 weeks ago
Attention: Patch coverage is 95.05300%
with 14 lines
in your changes missing coverage. Please review.
Project coverage is 74.88%. Comparing base (
80ac66f
) to head (6e3e480
).
Files | Patch % | Lines |
---|---|---|
Source/Project/Model/SMModel.f90 | 75.60% | 10 Missing :warning: |
Source/Mesh/MeshGeneratorMethods.f90 | 97.69% | 3 Missing :warning: |
Source/HOHQMesh.f90 | 80.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I've updated everything I can think of. One thing especially open for discussion is that I append "R" to a boundary name on the reflected portion of the mesh. I guess if one does not want that, it's a quick search/replace (maybe) in the file. Maybe something else truly unique would be better ? "#R?
No, there's nothing that you have to do. Just call at least one of the boundary curves "symmetry" when you are generating a model and off it will go. (Hey, this might be a way to define an interior boundary! If one of the curves along a line is called symmetry and the others aren't, then the nodes will be duplicated, along those others and the curve names are not deleted. Hmm.) This is what one user was asking for at one point. This does work, but messages saying that there are duplicate nodes are posted. That's OK, because one expects that to happen. Huh.
Add capability to take a mesh and reflect it about a (straight line) boundary with the name "symmetry". This should answer the request of some users for a symmetric mesh. TODO: Add example, testing, documentation, and test the mesh files.