codecov-commenter
commented
5 months ago Codecov Report
Attention: Patch coverage is 27.77778% with 13 lines in your changes are missing coverage. Please review.
Project coverage is 74.86%. Comparing base (
ce24fd3) to head (f59c553).:exclamation: Current head f59c553 differs from pull request most recent head be5991a. Consider uploading reports for the commit be5991a to get more accurate results
| Files | Patch % | Lines |
|---|---|---|
| src/grid_nhs.jl | 33.33% | 10 Missing :warning: |
| src/trivial_nhs.jl | 0.00% | 3 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #5 +/- ## ========================================== - Coverage 75.66% 74.86% -0.80% ========================================== Files 7 7 Lines 189 191 +2 ========================================== Hits 143 143 - Misses 46 48 +2 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/PointNeighbors.jl/pull/5/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/trixi-framework/PointNeighbors.jl/pull/5/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `74.86% <27.77%> (-0.80%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
With this PR, I pass both system's coordinates to the NHS, together with the information which of the coordinates are changing and which are static. The NHS can then decide if and what to update.
For example, the grid NHS doesn't need to update for fluid-boundary NHS. A neighborhood search that explicitly computes the neighbor lists will have to update them because the fluid particles are moving.