Closed efaulhaber closed 3 months ago
Attention: Patch coverage is 85.00000%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 89.83%. Comparing base (
35ed828
) to head (d8ff817
).
Files | Patch % | Lines |
---|---|---|
src/cell_lists/full_grid.jl | 76.92% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Based on #49.
I basically changed what the commit says: "Subtract
min_corner
incell_coords
instead of subtractingmin_cell
ingetindex
".Previously,
cell_coords
returned the absolute cell coordinates, then the neighbor cells around these were computed, and for each of those neighbor cells, the offsetmin_cell
had to be subtracted. Now, I subtract themin_corner
incell_coordinates
, so that we don't have to do this for every neighboring cell.On the CPU, the difference is small:
On the GPU (RTX 3090), however, the difference is huge. Even for the real-life WCSPH benchmark: