trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

Estimates of wave speeds #134

Open ranocha opened 3 years ago

ranocha commented 3 years ago

Often, we need some estimates of the wave speeds, e.g.

~Can/shall we try to create some unified interface for these estimates?~ We created a unified interface for wave speed estimates in #493. Now, we shall to add more sophisticated wave speed estimates, e.g.

gregorgassner commented 3 years ago

1.) I wonder if we should relate this to making scalar nodal functions (e.g. pressure), and one could be to compute the maximum wave speeds.

In general, I prefer to encapsulate the equation of state...as this would in theory allow us to change to another EOS a bit simpler...

2.) In general I like the idea to play around with the wave speeds. Especially for the Riemann solvers there is an impact in the choice of the wave speeds, e.g. the HLL or HLLC ones. However, I am not sure how immediate this problem is right now, or maybe something to keep for future experiments with a possible FV solver in Trixi.

ranocha commented 3 years ago

Sounds good to me. From my point of view, there are more important things to do right now (MPI, Taal), so we will keep this on our radar and come back to it later.

DanielDoehring commented 9 months ago

See PRs #1545 and https://github.com/trixi-framework/Trixi.jl/pull/1561