Parabolic AMR: Open discussions - Githubissues

trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia

https://trixi-framework.github.io/Trixi.jl

MIT License

542 stars 110 forks source link

Parabolic AMR: Open discussions #1690

Open DanielDoehring opened 1 year ago

DanielDoehring commented 1 year ago

To summarize the discussions in https://github.com/trixi-framework/Trixi.jl/pull/1629 I list some open points:

Outer datastructures for non-internal variables in ViscousContainers: https://github.com/trixi-framework/Trixi.jl/blob/474410507181fa93cbe8201da4ade03311f09104/src/solvers/dgsem_tree/container_viscous_2d.jl#L3-L15 Usage of Tuple also for noninternal datastructures?
Different reinitialize_containers! for parabolic cache (?) to avoid the if in https://github.com/trixi-framework/Trixi.jl/blob/474410507181fa93cbe8201da4ade03311f09104/src/solvers/dgsem_tree/containers.jl#L31-L35
Alternative to specialization via flux_viscous? https://github.com/trixi-framework/Trixi.jl/blob/dc0dc1d220e79d31465818acae235adf69ecddea/src/solvers/dgsem_tree/dg_2d_parabolic.jl#L518-L523

DanielDoehring commented 12 months ago

Corresponding PR: https://github.com/trixi-framework/Trixi.jl/pull/1754