Closed ranocha closed 4 months ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
.Created with :heart: by the Trixi.jl community.
CI is still running, so it looks like this hotfix works for now.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.28%. Comparing base (
e205b06
) to head (3364410
). Report is 3 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This should fix our recent CI failures on Windows and macOS related to ancient versions of FFMPEG, e.g.,
It looks like the reason is that the package manager prefers a newer version of FFMPEG_jll that is not yet allowed by FFMPEG.jl (but there is the PR https://github.com/JuliaIO/FFMPEG.jl/pull/59): I was able to reproduce getting the old version as follows.
Manifest.toml
and use the current clone of Trixi.jljulia +1.9 --project=.
(Trixi) pkg> build
julia> ENV["TRIXI_TEST"] = "none"
(Trixi) pkg> test Trixi
Then, I inspected the generated
Manifest.toml
:Updating yields
Let's see whether it works.
Closes #1852