trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

force new FFMPEG.jl version for tests #1858

Closed ranocha closed 4 months ago

ranocha commented 4 months ago

This should fix our recent CI failures on Windows and macOS related to ancient versions of FFMPEG, e.g.,

It looks like the reason is that the package manager prefers a newer version of FFMPEG_jll that is not yet allowed by FFMPEG.jl (but there is the PR https://github.com/JuliaIO/FFMPEG.jl/pull/59): I was able to reproduce getting the old version as follows.

  1. Remove Manifest.toml and use the current clone of Trixi.jl
  2. julia +1.9 --project=.
  3. (Trixi) pkg> build
  4. julia> ENV["TRIXI_TEST"] = "none"
  5. (Trixi) pkg> test Trixi

Then, I inspected the generated Manifest.toml:

(debug) pkg> status --manifest --outdated
Status `debug/Manifest.toml`
...
⌃ [c87230d0] FFMPEG v0.2.4 (<v0.4.1)

Updating yields

(debug) pkg> add FFMPEG@v0.4
   Resolving package versions...
    Updating `debug/Project.toml`
  [c87230d0] + FFMPEG v0.4.1
    Updating `debug/Manifest.toml`
  [b99e7846] - BinaryProvider v0.5.10
  [c87230d0] ↑ FFMPEG v0.2.4 ⇒ v0.4.1
⌅ [b22a6f82] ↓ FFMPEG_jll v6.1.1+0 ⇒ v4.4.4+1

Let's see whether it works.

Closes #1852

github-actions[bot] commented 4 months ago

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

Code quality

Documentation

Testing

Performance

Verification

Created with :heart: by the Trixi.jl community.

ranocha commented 4 months ago

CI is still running, so it looks like this hotfix works for now.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.28%. Comparing base (e205b06) to head (3364410). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1858 +/- ## ======================================= Coverage 96.28% 96.28% ======================================= Files 438 438 Lines 35386 35386 ======================================= Hits 34071 34071 Misses 1315 1315 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1858/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1858/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `96.28% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.