Closed DanielDoehring closed 7 months ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
.Created with :heart: by the Trixi.jl community.
Attention: Patch coverage is 96.15385%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 96.30%. Comparing base (
4bf61a0
) to head (2b47577
).
Files | Patch % | Lines |
---|---|---|
src/meshes/tree_mesh.jl | 50.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Motivated by #752
This puts out warnings if a mesh with periodic boundaries is used, but still BCs are supplied. The converse case, where a non-periodic mesh and periodic BCs are paired returns an error, so no additional treatment is added here.