Closed benegee closed 4 months ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
.Created with :heart: by the Trixi.jl community.
Attention: Patch coverage is 0%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 89.44%. Comparing base (
b11bc10
) to head (485355a
). Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/meshes/mesh_io.jl | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks! Did you check whether loading a mesh in serial works when you save it in parallel with a small capacity? I don't remember right now whether the capacity is a local one or needs to be big enough to store the data from all MPI ranks in parallel. That's why I'm asking.
The capacity is always global. Since the TreeMesh is parallelized by keeping a full copy on each rank and just syncing it between the processes, a "local" capacity does not make much sense anyways
Thanks for the explanation. I would not have known.
I only tested running the simulation in parallel and reading the results in serial via Trixi2Vtk.
Resolves #1861