Closed DanielDoehring closed 3 months ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
.Created with :heart: by the Trixi.jl community.
Attention: Patch coverage is 83.75000%
with 13 lines
in your changes are missing coverage. Please review.
Project coverage is 74.79%. Comparing base (
641fde8
) to head (10a2d72
).
Files | Patch % | Lines |
---|---|---|
src/equations/linearized_euler_1d.jl | 76.60% | 11 Missing :warning: |
...em/elixir_linearizedeuler_characteristic_system.jl | 93.10% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @lchristm for your review!
Thanks @andrewwinters5000 for the review! The CI failures are solely due to codevov, so this should also be ready to merge.
@lchristm Are we good to merge?
@andrewwinters5000 Yes, looks good to me! Thanks again for adding this feature, @DanielDoehring
The only failures are from CodeCov strangeness, is it okay to merge this @sloede @ranocha ?
Yes. Thanks!
This adds the linearized Euler equations in 1D. This comes with 3 examples: The usual convergence test, a somewhat nontrivial example with walls and an elixir that illustrates the computation of the analytical solution using the eigensystem.