trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

1D Linearized Euler #1867

Closed DanielDoehring closed 3 months ago

DanielDoehring commented 4 months ago

This adds the linearized Euler equations in 1D. This comes with 3 examples: The usual convergence test, a somewhat nontrivial example with walls and an elixir that illustrates the computation of the analytical solution using the eigensystem.

github-actions[bot] commented 4 months ago

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

Code quality

Documentation

Testing

Performance

Verification

Created with :heart: by the Trixi.jl community.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 83.75000% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 74.79%. Comparing base (641fde8) to head (10a2d72).

Files Patch % Lines
src/equations/linearized_euler_1d.jl 76.60% 11 Missing :warning:
...em/elixir_linearizedeuler_characteristic_system.jl 93.10% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1867 +/- ## =========================================== - Coverage 96.32% 74.79% -21.54% =========================================== Files 445 448 +3 Lines 35926 35947 +21 =========================================== - Hits 34605 26883 -7722 - Misses 1321 9064 +7743 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1867/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1867/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `74.79% <83.75%> (-21.54%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DanielDoehring commented 3 months ago

Thanks @lchristm for your review!

DanielDoehring commented 3 months ago

Thanks @andrewwinters5000 for the review! The CI failures are solely due to codevov, so this should also be ready to merge.

andrewwinters5000 commented 3 months ago

@lchristm Are we good to merge?

lchristm commented 3 months ago

@andrewwinters5000 Yes, looks good to me! Thanks again for adding this feature, @DanielDoehring

andrewwinters5000 commented 3 months ago

The only failures are from CodeCov strangeness, is it okay to merge this @sloede @ranocha ?

ranocha commented 3 months ago

Yes. Thanks!