trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

Add ExplicitImports.jl test #1875

Closed JoshuaLampert closed 3 months ago

JoshuaLampert commented 3 months ago

This adds a test using ExplicitImports.jl to check whether we have unused explicit imports or any implicit imports. It also includes the necessary changes to make the test pass.

github-actions[bot] commented 3 months ago

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

Code quality

Documentation

Testing

Performance

Verification

Created with :heart: by the Trixi.jl community.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.48%. Comparing base (2dfde7f) to head (3bb2ffa).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1875 +/- ## ========================================== - Coverage 96.30% 89.48% -6.82% ========================================== Files 439 439 Lines 35749 35738 -11 ========================================== - Hits 34428 31979 -2449 - Misses 1321 3759 +2438 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1875/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1875/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `89.48% <ø> (-6.82%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JoshuaLampert commented 3 months ago

Codecov seems to be down for some reason. And then there are the known t8code issues again.

JoshuaLampert commented 3 months ago

Closing and reopening this PR to trigger CI again (I don't have the rights to rerun the jobs without closing and opening).

JoshuaLampert commented 3 months ago

Codecov is down again...