Open benegee opened 3 months ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
.Created with :heart: by the Trixi.jl community.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.30%. Comparing base (
909abb4
) to head (feeb716
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Removing the
if n_boundaries > 0
check fixes #1878.Nothing will be done on the rank with 0 boundaries but
p4est_iterate
and ultimatelyMPI AllReduce
will be called by all ranks.The other checks for the mortars seem to be likewise at risk to me.