trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

Fix hanging P4est MPI simulation with boundary conditions #1879

Open benegee opened 3 months ago

benegee commented 3 months ago

Removing the if n_boundaries > 0 check fixes #1878.

Nothing will be done on the rank with 0 boundaries but p4est_iterate and ultimately MPI AllReduce will be called by all ranks.

The other checks for the mortars seem to be likewise at risk to me.

github-actions[bot] commented 3 months ago

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

Code quality

Documentation

Testing

Performance

Verification

Created with :heart: by the Trixi.jl community.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.30%. Comparing base (909abb4) to head (feeb716).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1879 +/- ## ========================================== - Coverage 96.30% 96.30% -0.00% ========================================== Files 440 440 Lines 35793 35790 -3 ========================================== - Hits 34470 34467 -3 Misses 1323 1323 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1879/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1879/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `96.30% <ø> (-<0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.