Closed bennibolm closed 6 months ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
.Created with :heart: by the Trixi.jl community.
Attention: Patch coverage is 93.75000%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 96.31%. Comparing base (
01032aa
) to head (51ad911
).
Files | Patch % | Lines |
---|---|---|
src/callbacks_stage/subcell_bounds_check_2d.jl | 92.86% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Polyester.jl supports an automatic reduction functionality with
@batch
since the newest version v0.7.10. The bounds check of subcell limiting requires a reduction step of deviations, which created a lot of issue due to False Sharing in the past. After some testing and discussion, I implemented a relatively ugly fix in PR #1736. With the new Polyester functionality, we can achieve a much nicer solution with approximately the same performance and scaleability.Test within branch
bennibolm/subcell-limiting
and fix inbennibolm/subcell-limiting-@batch-reduction
Time results of the bounds check are