trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

Add cubed sphere constructor to T8CodeMesh #1891

Closed benegee closed 3 months ago

benegee commented 3 months ago

Use t8code's t8_cmesh_new_cubed_spherical_shell.

github-actions[bot] commented 3 months ago

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

Code quality

Documentation

Testing

Performance

Verification

Created with :heart: by the Trixi.jl community.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 124 lines in your changes are missing coverage. Please review.

Project coverage is 95.97%. Comparing base (909abb4) to head (bc36a1a). Report is 1 commits behind head on main.

Files Patch % Lines
...de_3d_dgsem/elixir_euler_baroclinic_instability.jl 0.00% 98 Missing :warning:
src/meshes/t8code_mesh.jl 0.00% 26 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1891 +/- ## ========================================== - Coverage 96.30% 95.97% -0.33% ========================================== Files 440 442 +2 Lines 35793 35923 +130 ========================================== + Hits 34470 34476 +6 - Misses 1323 1447 +124 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1891/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1891/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `95.97% <0.00%> (-0.33%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

benegee commented 3 months ago

Superseded by #1900