Closed DanielDoehring closed 5 months ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
.Created with :heart: by the Trixi.jl community.
Note that I know the reasoning behind the argument for
eachindex
, but that personally I am happy with the style we currently use, as it is IMHO clearer to reason about as a novice user and while debugging. Having said that, I wouldn't stand in the way of this being merged if you feel strongly about it 😊 (and I have been wrong about the virtues of generic programming in the past 🤷♂️)
No strong feelings involved, but I got somewhat annoyed by the tooltips and wanted to give this a shot. Let's see if tests pass once OrdinaryDiffEq compiles again.
https://github.com/SciML/NonlinearSolve.jl/issues/402 seems to have triggered a fix for the failing compilation - thanks @ranocha 🙏
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.30%. Comparing base (
c025873
) to head (acac1b7
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Chris Rackauckas recommends
eachindex
over1:length