Closed andrewwinters5000 closed 2 months ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
.Created with :heart: by the Trixi.jl community.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.30%. Comparing base (
c6fc9c5
) to head (d06320e
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks Andrew for the additional comments, it is always helpful to have a second person expressing their understanding!
No problem! It is easy to lose track of the normal scaling and what is meant between normal_direction
and a normal_vector
. So, these extra comments hopefully avoid headaches in the future.
This adds the
x
coordinate and the timet
as input arguments for thevariable
function that can be integrated along a physical boundary viaAnalysisSurfaceIntegral
. This will allow the callback to compute integrated quantities on boundaries that depend on the solutionu
as well as boundary data that may be space and/or time dependent. Currently, thevariable
function can only use the solutionu
to compute boundary quantities.