trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
527 stars 104 forks source link

LinearizedEuler3D #1903

Closed DanielDoehring closed 5 months ago

github-actions[bot] commented 5 months ago

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

Code quality

Documentation

Testing

Performance

Verification

Created with :heart: by the Trixi.jl community.

DanielDoehring commented 5 months ago

Thanks @lchristm ! I slightly adjusted the wall example, the rest I left untouched.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 95.04950% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 96.30%. Comparing base (b1a84a6) to head (fc7e86b).

Files Patch % Lines
src/equations/linearized_euler_3d.jl 94.74% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1903 +/- ## ========================================== + Coverage 96.12% 96.30% +0.18% ========================================== Files 448 450 +2 Lines 36081 36182 +101 ========================================== + Hits 34682 34843 +161 + Misses 1399 1339 -60 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1903/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1903/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `96.30% <95.05%> (+0.18%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DanielDoehring commented 5 months ago

IMO, this is ready to go - any mergers @andrewwinters5000 @jlchan @ranocha @sloede ?

sloede commented 5 months ago

Note: EOC numbers to confirm expected convergence can be found here: https://github.com/trixi-framework/Trixi.jl/pull/1903#discussion_r1565415218