Closed DanielDoehring closed 5 months ago
Thanks @lchristm ! I slightly adjusted the wall example, the rest I left untouched.
Attention: Patch coverage is 95.04950%
with 5 lines
in your changes are missing coverage. Please review.
Project coverage is 96.30%. Comparing base (
b1a84a6
) to head (fc7e86b
).
Files | Patch % | Lines |
---|---|---|
src/equations/linearized_euler_3d.jl | 94.74% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
IMO, this is ready to go - any mergers @andrewwinters5000 @jlchan @ranocha @sloede ?
Note: EOC numbers to confirm expected convergence can be found here: https://github.com/trixi-framework/Trixi.jl/pull/1903#discussion_r1565415218
Review checklist
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
Purpose and scope
Code quality
Documentation
NEWS.md
.Testing
Performance
Verification
Created with :heart: by the Trixi.jl community.