search

trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

Workaround for failing Codecov runs #1905

Open ranocha opened 2 months ago

ranocha commented 2 months ago

Xref https://github.com/codecov/feedback/issues/301

huiyuxie commented 1 month ago

Then how do you know a PR is ready to be merged with a always failing CI? @ranocha

JoshuaLampert commented 1 month ago

We just have a look at the test reports. If all real tests pass, but only the step uploading the Codecov report fails because of precisely this issue, we (basically) know it's fine.

JoshuaLampert commented 1 month ago

Or we rerun CI until Codecov is happy. Of course, this is not ideal.

huiyuxie commented 1 month ago

Good. Hope this gets resolved soon.