trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

Perk p2 single ext #1908

Closed warisa-r closed 1 month ago

warisa-r commented 2 months ago

Hello,

in this PR which is a continuation of the previous PR of PERK2_single, I tried to make Convex and ECOS weak dependencies of Trixi by adding a file called TrixiConvexECOSExt.

Please let me know if something goes wrong and needs improving!

github-actions[bot] commented 2 months ago

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

Code quality

Documentation

Testing

Performance

Verification

Created with :heart: by the Trixi.jl community.

ranocha commented 2 months ago

@DanielDoehring You can ping me for a final review once you're satisfied.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 86.66667% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 92.56%. Comparing base (887bab9) to head (7bc1ca3).

Files Patch % Lines
...ation/paired_explicit_runge_kutta/methods_PERK2.jl 85.44% 23 Missing :warning:
src/Trixi.jl 0.00% 4 Missing :warning:
ext/TrixiConvexECOSExt.jl 96.23% 2 Missing :warning:
...aired_explicit_runge_kutta/polynomial_optimizer.jl 90.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1908 +/- ## ========================================== - Coverage 96.15% 92.56% -3.58% ========================================== Files 454 457 +3 Lines 36509 36702 +193 ========================================== - Hits 35102 33972 -1130 - Misses 1407 2730 +1323 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1908/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1908/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `92.56% <86.67%> (-3.58%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sloede commented 2 months ago

Doing a review today (maybe 60% done)

sloede commented 2 months ago

Both test failures looks real: https://github.com/trixi-framework/Trixi.jl/actions/runs/8950168743/job/24585250457?pr=1908#step:7:2058 https://github.com/trixi-framework/Trixi.jl/actions/runs/8950168743/job/24585251161?pr=1908#step:7:1372

sloede commented 1 month ago

@warisa-r I just noticed that a NEWS.md item is missing. Please go through the review checklist once more and that there's nothing else that was forgotten

DanielDoehring commented 1 month ago

Are we good to go here?