Closed warisa-r closed 1 month ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
.Created with :heart: by the Trixi.jl community.
@DanielDoehring You can ping me for a final review once you're satisfied.
Attention: Patch coverage is 86.66667%
with 30 lines
in your changes are missing coverage. Please review.
Project coverage is 92.56%. Comparing base (
887bab9
) to head (7bc1ca3
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Doing a review today (maybe 60% done)
@warisa-r I just noticed that a NEWS.md
item is missing. Please go through the review checklist once more and that there's nothing else that was forgotten
Are we good to go here?
Hello,
in this PR which is a continuation of the previous PR of PERK2_single, I tried to make Convex and ECOS weak dependencies of Trixi by adding a file called TrixiConvexECOSExt.
Please let me know if something goes wrong and needs improving!