Open jmark opened 2 months ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
.Created with :heart: by the Trixi.jl community.
There are some significant changes in the error values, e.g., here. So basically, elixir_euler_baroclinic_instability.jl doesn't work at all anymore. Do you know what's happening there, @jmark?
Ah, I see. This is one of the new elixirs. So looks like there is still some bug somewhere with this elixir.
Attention: Patch coverage is 0%
with 111 lines
in your changes missing coverage. Please review.
Project coverage is 88.68%. Comparing base (
f59322c
) to head (e9fc20f
).
Files | Patch % | Lines |
---|---|---|
...de_3d_dgsem/elixir_euler_baroclinic_instability.jl | 0.00% | 98 Missing :warning: |
src/meshes/t8code_mesh.jl | 0.00% | 13 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is a follow-PR to https://github.com/trixi-framework/Trixi.jl/pull/1900.
It implements two cubed spherical shell setups and uses the latest t8code v2.0.0 release.
Closes #1921