trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

Load `current_filename` for `Unstructured2D` and `P4est` `Meshes` #1923

Closed DanielDoehring closed 2 months ago

DanielDoehring commented 2 months ago

There was an inconsistency between the mesh types: For Structured and TreeMesh the current_filename variable was correctly set, while for P4est and Unstructured2D this was not the case.

I discovered this when restarting a simulation, from which I saved solutions for which no mesh was specified, resulting in error when applying Trixi2Vtk.

github-actions[bot] commented 2 months ago

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

Code quality

Documentation

Testing

Performance

Verification

Created with :heart: by the Trixi.jl community.

sloede commented 2 months ago

can you maybe reopen this from a branch within Trixi.jl? Otherwise, can you please check if all errors are only codecov related?

DanielDoehring commented 2 months ago

See #1924