Closed huiyuxie closed 1 month ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
.Created with :heart: by the Trixi.jl community.
Attention: Patch coverage is 0%
with 12 lines
in your changes are missing coverage. Please review.
Project coverage is 91.13%. Comparing base (
c221bca
) to head (d7716cb
).
Files | Patch % | Lines |
---|---|---|
src/auxiliary/math.jl | 0.00% | 12 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the review @ranocha ! I am thinking about how to test these PRs. Generally, I would treat these smaller PRs as preliminary improvements (as the general PR is calling some basic functions here). So basically we could test and merge these smaller PRs first then merge and test the general PR. But what if some PRs are cross-referencing each other (for example, some PRs rely on the improvements from each other)?
I am not sure whether the case I mentioned above is going to happen in these improvements.
Thanks for the review @ranocha ! I am thinking about how to test these PRs. Generally, I would treat these smaller PRs as preliminary improvements (as the general PR is calling some basic functions here). So basically we could test and merge these smaller PRs first then merge and test the general PR. But what if some PRs are cross-referencing each other (for example, some PRs rely on the improvements from each other)?
I am not sure whether the case I mentioned above is going to happen in these improvements.
In this case, the PRs providing functionality required by other changes should be merged first.
This depends on #1909 (or at least similar issues apply), right? If yes, please re-request my review here once changes in #1909 that are also pertinent for this PR here have been applied here as well 🙂
Rerun CI please (if you like). I locally ran CI when these were running here - hitting the limit and thus too many CI failures here.
The first extra part of #1909, mainly addressing src/auxiliary.
TODO: https://github.com/trixi-framework/Trixi.jl/pull/1929#discussion_r1590639060