trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

Add 1D `DGMulti` `GaussSBP` solver #1930

Closed jlchan closed 1 month ago

jlchan commented 1 month ago

GaussSBP solvers previously were only implemented in 2D and 3D. This PR adds 1D capabilities (using that sum factorization just reduces to mul! in 1D).

github-actions[bot] commented 1 month ago

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

Code quality

Documentation

Testing

Performance

Verification

Created with :heart: by the Trixi.jl community.

jlchan commented 1 month ago

Thanks for the quick review!

ranocha commented 1 month ago

Codecov is failing but I would like to see whether CI covers the new code...

ranocha commented 1 month ago

Maybe you can push this branch to a branch in the main repo and open a new PR so that we don't have the problem with codecov?

jlchan commented 1 month ago

Maybe you can push this branch to a branch in the main repo and open a new PR so that we don't have the problem with codecov?

Sure, no problem

jlchan commented 1 month ago

Superceded by #1932