trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

CompatHelper: bump compat for CairoMakie to 0.12 for package test, (keep existing compat) #1936

Open github-actions[bot] opened 1 month ago

github-actions[bot] commented 1 month ago

This pull request changes the compat entry for the CairoMakie package from 0.10 to 0.10, 0.12 for package test. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

TODO

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.16%. Comparing base (c221bca) to head (619575d).

Files Patch % Lines
ext/TrixiMakieExt.jl 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1936 +/- ## ========================================== - Coverage 96.09% 91.16% -4.94% ========================================== Files 453 453 Lines 36481 36477 -4 ========================================== - Hits 35055 33251 -1804 - Misses 1426 3226 +1800 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1936/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1936/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `91.16% <0.00%> (-4.94%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ranocha commented 1 month ago

The CI failure looks real to me:

  type Camera3D has no field attributes
  Stacktrace:
    [1] getproperty(x::Makie.Camera3D, f::Symbol)
      @ Base ./Base.jl:37
    [2] iplot(pd::Trixi.PlotData2DTriangulated{StructArrays.StructArray{StaticArraysCore.SVector{4, Float64}, 2, NTuple{4, Matrix{Float64}}, Int64}, Matrix{Float64}, Matrix{Float64}, StructArrays.StructArray{StaticArraysCore.SVector{4, Float64}, 2, NTuple{4, Matrix{Float64}}, Int64}, StaticArraysCore.SVector{4, String}, Matrix{Int32}}; plot_mesh::Bool, show_axis::Bool, colormap::Symbol, variable_to_plot_in::Int64)
      @ TrixiMakieExt ~/work/Trixi.jl/Trixi.jl/ext/TrixiMakieExt.jl:265

see https://github.com/trixi-framework/Trixi.jl/actions/runs/9027943539/job/24807599498?pr=1936#step:7:3305

@asinghvi17 Since you created https://github.com/trixi-framework/Trixi.jl/pull/1937, do you have a suggestion how to fix this?

asinghvi17 commented 1 month ago

Ah I didn't see that! Will look into it.

ranocha commented 1 month ago

Thanks a lot!

ranocha commented 1 month ago

Do you know in which version the shading options were updated like this?

┌ Warning: `shading = false` is not valid. Use `Makie.automatic`, `NoShading`, `FastShading` or `MultiLightShading`. Defaulting to `NoShading`.
└ @ Makie ~/.julia/packages/Makie/eziUH/src/lighting.jl:243

I would like to make sure that we don't get incompatible compatibility bounds in our Project.toml files.