Open github-actions[bot] opened 1 month ago
Attention: Patch coverage is 0%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 91.16%. Comparing base (
c221bca
) to head (619575d
).
Files | Patch % | Lines |
---|---|---|
ext/TrixiMakieExt.jl | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The CI failure looks real to me:
type Camera3D has no field attributes
Stacktrace:
[1] getproperty(x::Makie.Camera3D, f::Symbol)
@ Base ./Base.jl:37
[2] iplot(pd::Trixi.PlotData2DTriangulated{StructArrays.StructArray{StaticArraysCore.SVector{4, Float64}, 2, NTuple{4, Matrix{Float64}}, Int64}, Matrix{Float64}, Matrix{Float64}, StructArrays.StructArray{StaticArraysCore.SVector{4, Float64}, 2, NTuple{4, Matrix{Float64}}, Int64}, StaticArraysCore.SVector{4, String}, Matrix{Int32}}; plot_mesh::Bool, show_axis::Bool, colormap::Symbol, variable_to_plot_in::Int64)
@ TrixiMakieExt ~/work/Trixi.jl/Trixi.jl/ext/TrixiMakieExt.jl:265
@asinghvi17 Since you created https://github.com/trixi-framework/Trixi.jl/pull/1937, do you have a suggestion how to fix this?
Ah I didn't see that! Will look into it.
Thanks a lot!
Do you know in which version the shading options were updated like this?
┌ Warning: `shading = false` is not valid. Use `Makie.automatic`, `NoShading`, `FastShading` or `MultiLightShading`. Defaulting to `NoShading`.
└ @ Makie ~/.julia/packages/Makie/eziUH/src/lighting.jl:243
I would like to make sure that we don't get incompatible compatibility bounds in our Project.toml
files.
This pull request changes the compat entry for the
CairoMakie
package from0.10
to0.10, 0.12
for package test. This keeps the compat entries for earlier versions.Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.
TODO