trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

Provide document of numeric types and type stability #1938

Closed huiyuxie closed 1 month ago

huiyuxie commented 1 month ago

Covers #1909. It is just a start and later I will add more documentation.

github-actions[bot] commented 1 month ago

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

Code quality

Documentation

Testing

Performance

Verification

Created with :heart: by the Trixi.jl community.

huiyuxie commented 1 month ago

Please check again now :)

First, please check style, I try to keep consistency with the rest of the convention file. Second, concerning content, I think handling these cases on a case-by-case basis is acceptable for now (but I have no idea if this is good for other developers). Third, I suggest asking someone unfamiliar with these things to review it again. While you understand it clearly, it may not be as easy for others to grasp.

huiyuxie commented 1 month ago

Shall we merge this PR if it looks good to you, or should it be held until the main PR is ready to merge?

I think I should check the main PR again based on your provided notes. Please wait

huiyuxie commented 1 month ago

Thanks, these are good suggestions!