Closed huiyuxie closed 1 month ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
with its PR number.Created with :heart: by the Trixi.jl community.
Please check again now :)
First, please check style, I try to keep consistency with the rest of the convention file. Second, concerning content, I think handling these cases on a case-by-case basis is acceptable for now (but I have no idea if this is good for other developers). Third, I suggest asking someone unfamiliar with these things to review it again. While you understand it clearly, it may not be as easy for others to grasp.
Shall we merge this PR if it looks good to you, or should it be held until the main PR is ready to merge?
I think I should check the main PR again based on your provided notes. Please wait
Thanks, these are good suggestions!
Covers #1909. It is just a start and later I will add more documentation.