trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

Added Shu-Osher initialization for 1D compressible Euler with Gauss nodes #1943

Closed mleprovost closed 1 month ago

mleprovost commented 1 month ago

@jlchan I have added an example with the Shu-Osher initialization for the 1D compressible Euler with Gauss nodes (GaussSBP()).

I have slightly modified the initialization to avoid positivity issues.

The implementation uses a shock capturing. The time solver is SSPRK43 with adaptive time stepping.

For future work, add the ability to pass a positivity preserving limiter, e.g, PositivityPreservingLimiterZhangShu, for Gauss nodes to time-stepper SSPRK43?

github-actions[bot] commented 1 month ago

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

Code quality

Documentation

Testing

Performance

Verification

Created with :heart: by the Trixi.jl community.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.15%. Comparing base (fadfb3a) to head (4a923a2). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1943 +/- ## ======================================= Coverage 96.15% 96.15% ======================================= Files 453 454 +1 Lines 36485 36496 +11 ======================================= + Hits 35081 35092 +11 Misses 1404 1404 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1943/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1943/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `96.15% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sloede commented 1 month ago

The new elixir should be used in at least one test, to ensure that future changes to our API will not accidentally break it without anyone noticing.

JoshuaLampert commented 1 month ago

It looks like you have run the formatter with a different version than we use in our CI tests. Could you please rerun the formatter again with JuliaFormatter v1.0.45?

ranocha commented 1 month ago

It looks like some tests fail. Could you please check what's going on?

mleprovost commented 1 month ago

I fixed an error w.r.t the values of l2 and linf in the Shu Osher setting.

jlchan commented 1 month ago

That's odd. The DGMulti tests are still failing - and the failures appear to be due to real differences in the computed norms.

I wonder if it's related to https://github.com/trixi-framework/Trixi.jl/issues/881?

jlchan commented 1 month ago

There shouldn't be, but I'll double check tonight.

mleprovost commented 1 month ago

I realized that (Trixi)> test doesn't run all the tests, and I forgot to remove some stochasticity that I introduced in the initial condition as I was playing with the solver.