Closed andrewwinters5000 closed 1 month ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
with its PR number.Created with :heart: by the Trixi.jl community.
Attention: Patch coverage is 88.23529%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 96.15%. Comparing base (
6e5ff49
) to head (9a1d999
).
Files | Patch % | Lines |
---|---|---|
src/solvers/dgsem_structured/dg.jl | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is a bug fix where all mesh types other than
TreeMesh
should compute the solution mean valueu_mean
including the element Jacobians. If this is not done, it is possible to lose conservation. Typically, the values fromextra_analysis_errors = (:conservation_error,)
in theAnalysisCallback
should stay between1e-13
to1e-15
. However, when one computes the incorrect value foru_mean
on a curved mesh these conservation errors might increase to something between1e-4
to1e-8
(depending on the setup, how often the limiter is called, and how "warped" the mesh elements are).