Closed jlchan closed 1 month ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
with its PR number.Created with :heart: by the Trixi.jl community.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.15%. Comparing base (
887bab9
) to head (9a567d7
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@ranocha @JoshuaLampert I requested your reviews since you both commented on #1789. I am planning on merging PRs associated with this in a staging branch, and thought this might make it easier to review than a single large PR.
Let me know if you'd prefer to proceed otherwise
Is the MPI-macos test failure due to the Codecov issue when the PR is from a fork of the repo?
Is the MPI-macos test failure due to the Codecov issue when the PR is from a fork of the repo?
Yes, exactly. It would be easier if you could make the PRs from branches in the main repo
Thanks for taking care of this @jlchan!
Would address https://github.com/trixi-framework/Trixi.jl/issues/1906, and is the first step in addressing https://github.com/trixi-framework/Trixi.jl/issues/1789.