trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

remove Octavian and matmul! #1950

Closed jlchan closed 1 month ago

jlchan commented 1 month ago

Would address https://github.com/trixi-framework/Trixi.jl/issues/1906, and is the first step in addressing https://github.com/trixi-framework/Trixi.jl/issues/1789.

github-actions[bot] commented 1 month ago

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

Code quality

Documentation

Testing

Performance

Verification

Created with :heart: by the Trixi.jl community.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.15%. Comparing base (887bab9) to head (9a567d7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## jc/dev_DGMulti #1950 +/- ## =============================================== Coverage 96.15% 96.15% =============================================== Files 454 454 Lines 36509 36509 =============================================== + Hits 35102 35103 +1 + Misses 1407 1406 -1 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1950/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1950/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `96.15% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jlchan commented 1 month ago

@ranocha @JoshuaLampert I requested your reviews since you both commented on #1789. I am planning on merging PRs associated with this in a staging branch, and thought this might make it easier to review than a single large PR.

Let me know if you'd prefer to proceed otherwise

jlchan commented 1 month ago

Is the MPI-macos test failure due to the Codecov issue when the PR is from a fork of the repo?

ranocha commented 1 month ago

Is the MPI-macos test failure due to the Codecov issue when the PR is from a fork of the repo?

Yes, exactly. It would be easier if you could make the PRs from branches in the main repo

JoshuaLampert commented 1 month ago

Thanks for taking care of this @jlchan!