Open jlchan opened 1 month ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
with its PR number.Created with :heart: by the Trixi.jl community.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.03%. Comparing base (
c2513e2
) to head (c7b38bb
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I am running into issues due to Polyester.@batch
turning arrays into StrideArraysCore.PtrArrays". For a Navier-Stokes solve, this dispatches to Octavian.matmul!
via https://github.com/JuliaSIMD/StrideArrays.jl/blob/d31fb6cf28b0374162202da8c81694f2b704e0f3/src/blas.jl#L6.
For now, I'll just focus on the single-threaded case, but dealing with multi-threading will require figuring out if Polyester and StrideArrays will continue after stopping support of LoopVec.jl and Octavian.jl in Julia v1.11 (cc @chriselrod)
For a Navier-Stokes solve, this dispatches to Octavian.matmul! via https://github.com/JuliaSIMD/StrideArrays.jl/blob/d31fb6cf28b0374162202da8c81694f2b704e0f3/src/blas.jl#L6.
Feel free to PR it to drop Octavian as a dependency.
For now, I'll just focus on the single-threaded case, but dealing with multi-threading will require figuring out if Polyester and StrideArrays will continue after stopping support of LoopVec.jl and Octavian.jl in Julia v1.11
Regardless of the official status, you don't have to rush to make changes. There are no test failures on 1.11.
For a Navier-Stokes solve, this dispatches to Octavian.matmul! via https://github.com/JuliaSIMD/StrideArrays.jl/blob/d31fb6cf28b0374162202da8c81694f2b704e0f3/src/blas.jl#L6.
Feel free to PR it to drop Octavian as a dependency.
For now, I'll just focus on the single-threaded case, but dealing with multi-threading will require figuring out if Polyester and StrideArrays will continue after stopping support of LoopVec.jl and Octavian.jl in Julia v1.11
Regardless of the official status, you don't have to rush to make changes. There are no test failures on 1.11.
Thanks - I removed the LinearAlgebra.mul!
overloads in https://github.com/jlchan/StrideArrays.jl/blob/d31fb6cf28b0374162202da8c81694f2b704e0f3/src/blas.jl#L2-L36. It runs, but the solution gets NaN
s. When I switch @batch
to Threads.@threads
, I get an error that seems related to @turbo
:
ERROR: TaskFailedException
nested task error: UndefRefError: access to undefined reference
so I think I'm going to have to dig a little deeper beyond removing Octavian dependencies to figure out what's going wrong...
Also bumps StartUpDG.jl compat to 1.0.