trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

Add subcell limiting support for P4estMesh #1954

Open bennibolm opened 1 month ago

bennibolm commented 1 month ago

This PR includes:

TODO:

No support for non-conservative terms implemented yet.

Example: Supersonic cylinder Local two-sided limiting of density, positivity of pressure and local onesided limiting of entropy (guermond et al) No AMR. Initial refinement level for given mesh of 3 -> 35904 elements; polynomial degree of 3 rho alpha

github-actions[bot] commented 1 month ago

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

Code quality

Documentation

Testing

Performance

Verification

Created with :heart: by the Trixi.jl community.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 99.55556% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.18%. Comparing base (75d8c67) to head (eadcf6f).

Files Patch % Lines
src/callbacks_stage/subcell_bounds_check.jl 96.55% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1954 +/- ## ========================================== + Coverage 96.16% 96.18% +0.02% ========================================== Files 460 463 +3 Lines 36957 37138 +181 ========================================== + Hits 35537 35718 +181 Misses 1420 1420 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1954/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1954/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `96.18% <99.56%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.