Open bennibolm opened 1 month ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
with its PR number.Created with :heart: by the Trixi.jl community.
Attention: Patch coverage is 99.55556%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 96.18%. Comparing base (
75d8c67
) to head (eadcf6f
).
Files | Patch % | Lines |
---|---|---|
src/callbacks_stage/subcell_bounds_check.jl | 96.55% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR includes:
calc_bounds_twosided_interface
andcalc_bounds_onesided_interface
for P4estMeshget_boundary_outer_state
to allow normal directions, inner values (for slip wall), ...save_bounds_check_errors
fromsubcell_bounds_check_2d.jl
tosubcell_bounds_check.jl
TODO:
calc_bounds_twosided_boundary
for Periodic boundaries.No support for non-conservative terms implemented yet.
Example: Supersonic cylinder Local two-sided limiting of density, positivity of pressure and local onesided limiting of entropy (guermond et al) No AMR. Initial refinement level for given mesh of 3 -> 35904 elements; polynomial degree of 3