Closed efaulhaber closed 1 month ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
with its PR number.Created with :heart: by the Trixi.jl community.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.53%. Comparing base (
5359525
) to head (7d64acc
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
As discussed with @ranocha, the condition
integrator.stats.naccept == 0 && integrator.iter > 0
is an historical remnant that has just been copied around without really thinking about it.The callbacks are only triggered for accepted steps, so this condition is never true. The callback will only be initially triggered once with
naccept == iter == 0
and then always withiter >= naccept > 0
.