trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

first draft IMEX JinXin #1963

Open MarcoArtiano opened 1 month ago

MarcoArtiano commented 1 month ago

I made a first dirty and "straightforward" draft, but as I anticipated it might have some bugs. I still didn't generalize to keep it simple until I'm sure it will work. I broke it down to the simplest way to make it work, but I couldn't find any major mistakes.

github-actions[bot] commented 1 month ago

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

Code quality

Documentation

Testing

Performance

Verification

Created with :heart: by the Trixi.jl community.

MarcoArtiano commented 1 month ago

There was a missing sign on my implementation, now the code seems to run well. I'm gonna make further test, clean up everything and improve the implementation where is possible.

ranocha commented 4 weeks ago

Could you please run the code formatter as described in https://trixi-framework.github.io/Trixi.jl/stable/styleguide/?

MarcoArtiano commented 4 weeks ago

Could you please run the code formatter as described in https://trixi-framework.github.io/Trixi.jl/stable/styleguide/?

Done!

JoshuaLampert commented 2 weeks ago

Looks like you used another version of the JuliaFormatter for formatting resulting in many unrelated changes, see also #1976. Can you rerun the formatter with the other version, please?