Open MarcoArtiano opened 1 month ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
with its PR number.Created with :heart: by the Trixi.jl community.
There was a missing sign on my implementation, now the code seems to run well. I'm gonna make further test, clean up everything and improve the implementation where is possible.
Could you please run the code formatter as described in https://trixi-framework.github.io/Trixi.jl/stable/styleguide/?
Could you please run the code formatter as described in https://trixi-framework.github.io/Trixi.jl/stable/styleguide/?
Done!
Looks like you used another version of the JuliaFormatter for formatting resulting in many unrelated changes, see also #1976. Can you rerun the formatter with the other version, please?
I made a first dirty and "straightforward" draft, but as I anticipated it might have some bugs. I still didn't generalize to keep it simple until I'm sure it will work. I broke it down to the simplest way to make it work, but I couldn't find any major mistakes.