WIP: Add Legendre-Gauss basis for DGSEM and implement solver support for 2D TreeMesh

github-actions[bot] commented 1 month ago

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

[ ] The PR has a single goal that is clear from the PR title and/or description.
[ ] All code changes represent a single set of modifications that logically belong together.
[ ] No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

[ ] The code can be understood easily.
[ ] Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
[ ] There are no redundancies that can be removed by simple modularization/refactoring.
[ ] There are no leftover debug statements or commented code sections.
[ ] The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

[ ] New functions and types are documented with a docstring or top-level comment.
[ ] Relevant publications are referenced in docstrings (see example for formatting).
[ ] Inline comments are used to document longer or unusual code sections.
[ ] Comments describe intent ("why?") and not just functionality ("what?").
[ ] If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

[ ] The PR passes all tests.
[ ] New or modified lines of code are covered by tests.
[ ] New or modified tests run in less then 10 seconds.

Performance

[ ] There are no type instabilities or memory allocations in performance-critical parts.
[ ] If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

[ ] The correctness of the code was verified using appropriate tests.
[ ] If new equations/methods are added, a convergence test has been run and the results are posted in the PR.

Created with :heart: by the Trixi.jl community.

sloede commented 1 month ago

Convergence test results:

julia>  convergence_test("examples/tree_2d_dgsem/elixir_euler_convergence_gauss.jl", 5, tspan=(0.0, 0.1)

####################################################################################################
l2
rho                 rho_v1              rho_v2              rho_e
error     EOC       error     EOC       error     EOC       error     EOC
6.84e-07  -         8.45e-07  -         8.45e-07  -         2.69e-06  -
3.49e-08  4.29      4.30e-08  4.30      4.30e-08  4.30      1.56e-07  4.11
2.25e-09  3.95      2.81e-09  3.94      2.81e-09  3.94      9.84e-09  3.98
1.36e-10  4.05      1.70e-10  4.04      1.70e-10  4.04      6.13e-10  4.00
8.57e-12  3.99      1.08e-11  3.98      1.08e-11  3.98      3.83e-11  4.00

mean      4.07      mean      4.06      mean      4.06      mean      4.03
----------------------------------------------------------------------------------------------------
linf
rho                 rho_v1              rho_v2              rho_e
error     EOC       error     EOC       error     EOC       error     EOC
2.36e-06  -         3.08e-06  -         3.08e-06  -         1.30e-05  -
1.74e-07  3.77      2.15e-07  3.84      2.15e-07  3.84      9.16e-07  3.82
1.30e-08  3.74      1.61e-08  3.74      1.61e-08  3.74      6.05e-08  3.92
6.76e-10  4.26      8.31e-10  4.28      8.31e-10  4.28      3.50e-09  4.11
4.40e-11  3.94      5.59e-11  3.89      5.59e-11  3.89      2.27e-10  3.95

mean      3.93      mean      3.94      mean      3.94      mean      3.95
----------------------------------------------------------------------------------------------------
Dict{Symbol, Any} with 3 entries:
  :variables => ("rho", "rho_v1", "rho_v2", "rho_e")
  :l2        => [4.07106, 4.06455, 4.06455, 4.02501]
  :linf      => [3.92877, 3.93774, 3.9377, 3.95104]

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 80.15873% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 92.16%. Comparing base (3b52a30) to head (8a11896).

Files	Patch %	Lines
src/solvers/dgsem/basis_gauss_legendre.jl	72.97%	20 Missing :warning:
src/solvers/dgsem/dgsem.jl	57.14%	3 Missing :warning:
src/solvers/dgsem_tree/dg_2d.jl	95.56%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1965 +/- ## ========================================== - Coverage 96.11% 92.16% -3.95% ========================================== Files 460 461 +1 Lines 36926 37006 +80 ========================================== - Hits 35490 34104 -1386 - Misses 1436 2902 +1466 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1965/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `92.16% <80.16%> (-3.95%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

trixi-framework / Trixi.jl