Closed huiyuxie closed 1 week ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
with its PR number.Created with :heart: by the Trixi.jl community.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.16%. Comparing base (
e114d01
) to head (948914e
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm waiting for the previous one getting merged. There would possibly be conflicts in the unit test file and I don't like resolving code conflicts ;)
Ready for final review and merge @ranocha :/
Could you please resolve the conflicts so that we can merge this PR?
@ranocha Sure but I'm curious that you are unable to resolve this issue on your end?
That's why I request you to review and merge them timely - if not, my later PRs would easily get conflicts with the former PR.
I would be able to resolve the conflicts. But I would need to allocate more time for that. If you want to get this PR merged quickly, it will be faster if you resolve the conflicts.
Ok please merge ^^
@ranocha ^^
Continue #1909.
Tasks: