trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

Add numerical support of other real types (`navier`) #1968

Closed huiyuxie closed 1 week ago

huiyuxie commented 3 weeks ago

Continue #1909.

Tasks:

github-actions[bot] commented 3 weeks ago

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

Code quality

Documentation

Testing

Performance

Verification

Created with :heart: by the Trixi.jl community.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.16%. Comparing base (e114d01) to head (948914e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1968 +/- ## ======================================= Coverage 96.16% 96.16% ======================================= Files 460 460 Lines 36980 36980 ======================================= Hits 35560 35560 Misses 1420 1420 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1968/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1968/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `96.16% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

huiyuxie commented 3 weeks ago

I'm waiting for the previous one getting merged. There would possibly be conflicts in the unit test file and I don't like resolving code conflicts ;)

huiyuxie commented 1 week ago

Ready for final review and merge @ranocha :/

ranocha commented 1 week ago

Could you please resolve the conflicts so that we can merge this PR?

huiyuxie commented 1 week ago

@ranocha Sure but I'm curious that you are unable to resolve this issue on your end?

huiyuxie commented 1 week ago

That's why I request you to review and merge them timely - if not, my later PRs would easily get conflicts with the former PR.

ranocha commented 1 week ago

I would be able to resolve the conflicts. But I would need to allocate more time for that. If you want to get this PR merged quickly, it will be faster if you resolve the conflicts.

huiyuxie commented 1 week ago

Ok please merge ^^

huiyuxie commented 1 week ago

@ranocha ^^