trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

Add numerical support of other real types (`hyperbolic`) #1969

Closed huiyuxie closed 1 week ago

huiyuxie commented 3 weeks ago

Continue #1909.

Tasks:

github-actions[bot] commented 3 weeks ago

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

Code quality

Documentation

Testing

Performance

Verification

Created with :heart: by the Trixi.jl community.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.16%. Comparing base (57d1730) to head (911c609). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1969 +/- ## ======================================= Coverage 96.16% 96.16% ======================================= Files 460 460 Lines 36968 36980 +12 ======================================= + Hits 35548 35560 +12 Misses 1420 1420 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1969/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1969/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `96.16% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

huiyuxie commented 2 weeks ago

https://github.com/trixi-framework/Trixi.jl/blob/5398b2257a68c8795be4ee06b5ee3e947e006ff8/src/equations/hyperbolic_diffusion_1d.jl#L29-L32 Should we agree on that it is okay to let the default mode be Float64 when no argument is passed? @ranocha

ranocha commented 2 weeks ago

https://github.com/trixi-framework/Trixi.jl/blob/5398b2257a68c8795be4ee06b5ee3e947e006ff8/src/equations/hyperbolic_diffusion_1d.jl#L29-L32

Should we agree on that it is okay to let the default mode be Float64 when no argument is passed? @ranocha

Yes, that's fine 👍

huiyuxie commented 1 week ago

Ready for final review and merge @ranocha ^^