Closed huiyuxie closed 1 week ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
with its PR number.Created with :heart: by the Trixi.jl community.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.16%. Comparing base (
57d1730
) to head (911c609
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
https://github.com/trixi-framework/Trixi.jl/blob/5398b2257a68c8795be4ee06b5ee3e947e006ff8/src/equations/hyperbolic_diffusion_1d.jl#L29-L32
Should we agree on that it is okay to let the default mode be Float64
when no argument is passed? @ranocha
Should we agree on that it is okay to let the default mode be
Float64
when no argument is passed? @ranocha
Yes, that's fine 👍
Ready for final review and merge @ranocha ^^
Continue #1909.
Tasks: