trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

Add numerical support of other real types (`linear_advection`) #1971

Closed huiyuxie closed 2 weeks ago

huiyuxie commented 3 weeks ago

Continue #1909.

Linear advection seems easier to review and merge, so I do these first in equations.

Tasks:

github-actions[bot] commented 3 weeks ago

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

Code quality

Documentation

Testing

Performance

Verification

Created with :heart: by the Trixi.jl community.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.16%. Comparing base (6bb0be5) to head (23c0050).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1971 +/- ## ========================================== + Coverage 96.15% 96.16% +0.01% ========================================== Files 460 460 Lines 36949 36958 +9 ========================================== + Hits 35527 35539 +12 + Misses 1422 1419 -3 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1971/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1971/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `96.16% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

huiyuxie commented 3 weeks ago

Okay

huiyuxie commented 2 weeks ago

Ready for final review @ranocha :/