Closed jlchan closed 3 weeks ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
with its PR number.Created with :heart: by the Trixi.jl community.
There should be a test to catch this - there is not currently one, but I would propose making this a new issue instead of holding up https://github.com/trixi-framework/Trixi.jl/pull/1947/
Edit: ignore this comment, added a test in a098de3af688071fa41ec1581c4c9fd6086f56b4
Formatting fails.
Ah, I made some edits online so I didn't have a chance to run the formatter. One second.
Hopefully that fixes things
Doesn't look like the formatter is happy. Note that we use JuliaFormatter v1.0.45.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.14%. Comparing base (
2043cfe
) to head (95b176b
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the review!
Merging; all tests passed
Fixes https://github.com/trixi-framework/Trixi.jl/pull/1947/files#r1628569760