trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

Feature: Checkpointing for T8codeMesh #1980

Open jmark opened 2 weeks ago

jmark commented 2 weeks ago

This PR adds checkpointing for T8codeMesh. By this, routines like save_mesh and load_mesh are supported.

github-actions[bot] commented 2 weeks ago

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

Code quality

Documentation

Testing

Performance

Verification

Created with :heart: by the Trixi.jl community.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 73.18182% with 59 lines in your changes missing coverage. Please review.

Project coverage is 88.99%. Comparing base (58acd35) to head (6396931).

Files Patch % Lines
src/meshes/t8code_mesh.jl 75.64% 38 Missing :warning:
src/meshes/mesh_io.jl 68.97% 18 Missing :warning:
src/callbacks_step/save_restart_dg.jl 0.00% 3 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (58acd35) and HEAD (6396931). Click for more details.

HEAD has 3 uploads less than BASE | Flag | BASE (58acd35) | HEAD (6396931) | |------|------|------| |unittests|26|23|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1980 +/- ## ========================================== - Coverage 96.19% 88.99% -7.20% ========================================== Files 460 460 Lines 36993 37157 +164 ========================================== - Hits 35584 33065 -2519 - Misses 1409 4092 +2683 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1980/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1980/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `88.99% <73.18%> (-7.20%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.