trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

Do not set `finalstep = false` in PERK2 `step!` #1983

Closed DanielDoehring closed 2 weeks ago

DanielDoehring commented 2 weeks ago

The correct place to set this is in the solve! function:

https://github.com/trixi-framework/Trixi.jl/blob/5398b2257a68c8795be4ee06b5ee3e947e006ff8/src/time_integration/paired_explicit_runge_kutta/methods_PERK2.jl#L279-L286

github-actions[bot] commented 2 weeks ago

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

Code quality

Documentation

Testing

Performance

Verification

Created with :heart: by the Trixi.jl community.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.16%. Comparing base (5398b22) to head (7ceceb3).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1983 +/- ## ========================================== - Coverage 96.16% 96.16% -0.00% ========================================== Files 460 460 Lines 36958 36957 -1 ========================================== - Hits 35539 35538 -1 Misses 1419 1419 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1983/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1983/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `96.16% <ø> (-<0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.