trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

Add numerical support of other real types (`ideal`) #1984

Closed huiyuxie closed 17 hours ago

huiyuxie commented 2 weeks ago

Continue #1909.

Tasks:

github-actions[bot] commented 2 weeks ago

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

Code quality

Documentation

Testing

Performance

Verification

Created with :heart: by the Trixi.jl community.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.19%. Comparing base (179854e) to head (19f22ec).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1984 +/- ## ========================================== + Coverage 96.16% 96.19% +0.03% ========================================== Files 460 460 Lines 36984 36993 +9 ========================================== + Hits 35564 35584 +20 + Misses 1420 1409 -11 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1984/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1984/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `96.19% <100.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

huiyuxie commented 2 days ago

Ready for final review and merge @ranocha ^^

huiyuxie commented 1 day ago

Thanks! Please give me some time to look into those errors.

huiyuxie commented 1 day ago

Wow looks like it is fixed now ^^ that's amazing! Please check my comments above since I don't know why those integers cannot be Float32 - for me, they all passed the type tests.