Closed huiyuxie closed 17 hours ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
with its PR number.Created with :heart: by the Trixi.jl community.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.19%. Comparing base (
179854e
) to head (19f22ec
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ready for final review and merge @ranocha ^^
Thanks! Please give me some time to look into those errors.
Wow looks like it is fixed now ^^ that's amazing! Please check my comments above since I don't know why those integers cannot be Float32
- for me, they all passed the type tests.
Continue #1909.
Tasks: