trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

Add StructuredMeshView to fluxes. #1986

Closed SimonCan closed 1 hour ago

SimonCan commented 2 weeks ago

Added StructuredMeshView{2} to various flux functions to fix issue with some coupled simulations.

github-actions[bot] commented 2 weeks ago

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

Code quality

Documentation

Testing

Performance

Verification

Created with :heart: by the Trixi.jl community.

sloede commented 2 weeks ago

LGTM. Please run formatter, mark as ready for review, and re-request review 😊

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.19%. Comparing base (58acd35) to head (cb775a0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1986 +/- ## ======================================= Coverage 96.19% 96.19% ======================================= Files 460 460 Lines 36993 36993 ======================================= Hits 35584 35584 Misses 1409 1409 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1986/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Ξ” | | |---|---|---| | [unittests](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/1986/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `96.19% <100.00%> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SimonCan commented 1 week ago

LGTM. Please run formatter, mark as ready for review, and re-request review 😊

Thanks. Just applied it.