Closed andrewwinters5000 closed 21 hours ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
with its PR number.Created with :heart: by the Trixi.jl community.
Attention: Patch coverage is 86.66667%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 96.16%. Comparing base (
29eb55a
) to head (9ca5803
).
Files | Patch % | Lines |
---|---|---|
src/callbacks_step/save_solution_dg.jl | 50.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This needs downstream changes in Trixi2Vtk.jl.
@sloede Could you please review this PR as well? If you're fine, we can release this in v0.8 and make the appropriate changes to Trixi2Vtk.jl as noticed by @JoshuaLampert
This allows the number in the solution file name to max out at 999999999.