Open jlchan opened 4 days ago
This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.
NEWS.md
with its PR number.Created with :heart: by the Trixi.jl community.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.00%. Comparing base (
a160481
) to head (7233b57
).:exclamation: There is a different number of reports uploaded between BASE (a160481) and HEAD (7233b57). Click for more details.
HEAD has 1 upload less than BASE
| Flag | BASE (a160481) | HEAD (7233b57) | |------|------|------| |unittests|25|24|
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks!
Looks like the CI failure is real:
LoadError: "Memory access for Kronecker.KroneckerProduct{Float64, Matrix{Float64}, Matrix{Float64}} not implemented yet."
Thanks! I should be able to get to this after the holiday (July 4 in the US)
Currently, StartUpDG.jl <1.1.0 imports
NamedArrayPartition
from RecursiveArrayTools.jl. Due to compat bounds put in place because of #1789, this prevents us from using newer versions of StartUpDG.jl.This PR moves
NamedArrayPartition
back into StartUpDG.jl and lowers the compat requirement on RecursiveArrayTools.jl, hopefully making it compatible with Trixi.jl again.