trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
505 stars 98 forks source link

Bump StartUpDG.jl compat to 1.1.0 #2001

Open jlchan opened 4 days ago

jlchan commented 4 days ago

Currently, StartUpDG.jl <1.1.0 imports NamedArrayPartition from RecursiveArrayTools.jl. Due to compat bounds put in place because of #1789, this prevents us from using newer versions of StartUpDG.jl.

This PR moves NamedArrayPartition back into StartUpDG.jl and lowers the compat requirement on RecursiveArrayTools.jl, hopefully making it compatible with Trixi.jl again.

github-actions[bot] commented 4 days ago

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

Code quality

Documentation

Testing

Performance

Verification

Created with :heart: by the Trixi.jl community.

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.00%. Comparing base (a160481) to head (7233b57).

:exclamation: There is a different number of reports uploaded between BASE (a160481) and HEAD (7233b57). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (a160481) | HEAD (7233b57) | |------|------|------| |unittests|25|24|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2001 +/- ## =========================================== - Coverage 96.19% 83.00% -13.19% =========================================== Files 462 462 Lines 37027 36979 -48 =========================================== - Hits 35615 30693 -4922 - Misses 1412 6286 +4874 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/2001/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trixi-framework/Trixi.jl/pull/2001/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `83.00% <ø> (-13.19%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ranocha commented 4 days ago

Thanks!

Looks like the CI failure is real:

https://github.com/trixi-framework/Trixi.jl/actions/runs/9780885936/job/27003604009?pr=2001#step:7:1317

  LoadError: "Memory access for Kronecker.KroneckerProduct{Float64, Matrix{Float64}, Matrix{Float64}} not implemented yet."
jlchan commented 3 days ago

Thanks! I should be able to get to this after the holiday (July 4 in the US)